Implement web app definition parsing.

chrome/renderer/render_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 24 matching lines @@
 #include "chrome/common/file_system/file_system_dispatcher.h"
 #include "chrome/common/file_system/webfilesystem_callback_dispatcher.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/page_zoom.h"
 #include "chrome/common/pepper_plugin_registry.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/renderer_preferences.h"
 #include "chrome/common/thumbnail_score.h"
 #include "chrome/common/url_constants.h"
+#include "chrome/common/web_apps.h"
 #include "chrome/common/window_container_type.h"
 #include "chrome/renderer/about_handler.h"
 #include "chrome/renderer/audio_message_filter.h"
 #include "chrome/renderer/autofill_helper.h"
 #include "chrome/renderer/automation/dom_automation_controller.h"
 #include "chrome/renderer/blocked_plugin.h"
 #include "chrome/renderer/device_orientation_dispatcher.h"
 #include "chrome/renderer/devtools_agent.h"
 #include "chrome/renderer/devtools_client.h"
 #include "chrome/renderer/dom_ui_bindings.h"
@@ skipping 3849 matching lines @@
     webkit_glue::ImageDecoder decoder(gfx::Size(kFavIconSize, kFavIconSize));
     const unsigned char* src_data =
         reinterpret_cast<const unsigned char*>(&data[0]);
 
     return decoder.Decode(src_data, data.size());
   }
   return SkBitmap();
 }
 
 void RenderView::OnGetApplicationInfo(int page_id) {
-  webkit_glue::WebApplicationInfo app_info;
-  if (page_id == page_id_)
-    webkit_glue::GetApplicationInfo(webview(), &app_info);
+  WebApplicationInfo app_info;
+  if (page_id == page_id_) {
+    string16 error;
+    ParseWebAppFromWebDocument(webview()->mainFrame(), &app_info, &error);

[Erik does not do reviews, 2010/11/15 19:45:36]

Since this can fail, don't we need to punt if it returns false and error is set?
 Is there going to be a way to pass error up to the browser?

[Aaron Boodman, 2010/11/16 03:44:45]

No, the calling code in the browser process just defaults everything that it
doesn't find in app_info.

[Erik does not do reviews, 2010/11/16 23:43:02]

ok

+  }
 
   // Prune out any data URLs in the set of icons.  The browser process expects
   // any icon with a data URL to have originated from a favicon.  We don't want
   // to decode arbitrary data URLs in the browser process.  See
   // http://b/issue?id=1162972
   for (size_t i = 0; i < app_info.icons.size(); ++i) {
     if (app_info.icons[i].url.SchemeIs(chrome::kDataScheme)) {
       app_info.icons.erase(app_info.icons.begin() + i);
       --i;
     }
@@ skipping 1560 matching lines @@
       IPC::PlatformFileForTransitToPlatformFile(file_for_transit),
       message_id);
 }
 
 #if defined(OS_MACOSX)
 void RenderView::OnSelectPopupMenuItem(int selected_index) {
   external_popup_menu_->DidSelectItem(selected_index);
   external_popup_menu_.reset();
 }
 #endif