net/http/http_cache_unittest.cc - Issue 4974001: base: Get rid of 'using' declaration of StringAppendF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_unittest.cc

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_unittest.cc

diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc

index f71cec928c3477990f4075401bee157c2d897645..4d9eef074216c1e67de8d970af99b3d149fc79b6 100644

--- a/net/http/http_cache_unittest.cc

+++ b/net/http/http_cache_unittest.cc

@@ -905,7 +905,8 @@ void RangeTransactionServer::RangeHandler(const net::HttpRequestInfo* request,

EXPECT_EQ(9, (end - start) % 10);

std::string data;

for (int block_start = start; block_start < end; block_start += 10)

brettw 2010/11/15 00:09:23 This for statement needs {} now that you made the

tfarina 2010/11/15 01:21:25 Done.

- StringAppendF(&data, "rg: %02d-%02d ", block_start, block_start + 9);

+ base::StringAppendF(&data, "rg: %02d-%02d ",

+ block_start, block_start + 9);

*response_data = data;

if (end - start != 9) {