Issue 4971003: Inject MessageLoop into Capturer

Issue 4971003: Inject MessageLoop into Capturer (Closed)

Created:
10 years, 1 month ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
awong

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, pam+watch_chromium.org, awong, garykac

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Inject MessageLoop into Capturer Simple patch to juse inject the message loop. BUG=None TEST=None

Patch Set 1 #

Total comments: 6

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -24 lines)			Patch
M	chrome/service/service_process.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	remoting/host/capturer.h	View	3 chunks	+6 lines, -1 line	1 comment	Download
M	remoting/host/capturer.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	remoting/host/capturer_fake.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/host/capturer_fake.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	remoting/host/capturer_fake_ascii.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/host/capturer_fake_ascii.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/host/capturer_gdi.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/host/capturer_gdi.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	remoting/host/capturer_linux.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/host/capturer_linux.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	remoting/host/capturer_mac.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/host/capturer_mac.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	remoting/host/mock_objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/simple_host_process.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

10 years, 1 month ago (2010-11-16 00:42:12 UTC) #2

This is just an injection with no functionality change, correct?

If so, LGTM

Also fix up the CL comment. You have a typo.

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer.h
File remoting/host/capturer.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer.h#newcode47
remoting/host/capturer.h:47: Capturer(MessageLoop* message_loop);
explicit

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_fake.h
File remoting/host/capturer_fake.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_fake.h#n...
remoting/host/capturer_fake.h:19: CapturerFake(MessageLoop* message_loop);
explicit

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_fake_asc...
File remoting/host/capturer_fake_ascii.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_fake_asc...
remoting/host/capturer_fake_ascii.h:20: CapturerFakeAscii(MessageLoop*
message_loop);
explicit

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_gdi.h
File remoting/host/capturer_gdi.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_gdi.h#ne...
remoting/host/capturer_gdi.h:23: CapturerGdi(MessageLoop* message_loop);
explicit

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_linux.h
File remoting/host/capturer_linux.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_linux.h#...
remoting/host/capturer_linux.h:17: CapturerLinux(MessageLoop* message_loop);
explicit

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_mac.h
File remoting/host/capturer_mac.h (right):

http://codereview.chromium.org/4971003/diff/1/remoting/host/capturer_mac.h#ne...
remoting/host/capturer_mac.h:18: CapturerMac(MessageLoop* message_loop);
explicit

Expand Messages | Collapse Messages