Issue 497006: Ignore debug break events when bootstrapper is active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 497006: Ignore debug break events when bootstrapper is active. (Closed)

Created:
11 years ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Ignore debug break events when bootstrapper is active. Collecting debug data when the context is not yet setup may lead to subtle errors like in the following Chromium bug: http://crbug.com/28933 Committed: http://code.google.com/p/v8/source/detail?r=3465

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	src/execution.cc	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	test/cctest/test-debug.cc	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/497006/diff/6/7 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/497006/diff/6/7#newcode3161 test/cctest/test-debug.cc:3161: // Create a context with an extension to ...

11 years ago (2009-12-15 07:30:00 UTC) #2

yurys

11 years ago (2009-12-15 09:15:17 UTC) #3

http://codereview.chromium.org/497006/diff/6/7
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/497006/diff/6/7#newcode3161
test/cctest/test-debug.cc:3161: // Create a context with an extension to make
sure that some JavaScript
On 2009/12/15 07:30:00, Søren Gjesse wrote:
> 2 space indent.

Done.

Expand Messages | Collapse Messages