Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 4970003: [Chrome OS] Move cros deps inside the main chrome repo (Closed)

Created:
10 years, 1 month ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[Chrome OS] Move cros deps inside the main chrome repo Instead of forcing all linux devs to have an acceptable version of git installed, mitigate the problem of the cros_deps/DEPS file living outside the main chrome checkout by moving our extra DEPS file inside the main chrome tree. Also change our naming convention to be more like that which is in use elsewhere in the project. In a week, cros_deps/DEPS will be end-of-lifed. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66153

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A tools/cros.DEPS/DEPS View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Chris Masone
10 years, 1 month ago (2010-11-15 19:35:42 UTC) #1
bradn
LGTM http://codereview.chromium.org/4970003/diff/1/tools/cros.DEPS/DEPS File tools/cros.DEPS/DEPS (right): http://codereview.chromium.org/4970003/diff/1/tools/cros.DEPS/DEPS#newcode7 tools/cros.DEPS/DEPS:7: Var("chromium_git") + "/cros.git@d4465704", Is that a sufficiently precise ...
10 years, 1 month ago (2010-11-15 19:36:55 UTC) #2
Chris Masone
10 years, 1 month ago (2010-11-15 19:38:27 UTC) #3
That is generally considered to be sufficient.  it's standard within the
community, to teh best of my knowledge, and what we've been using so far.

On Mon, Nov 15, 2010 at 11:36 AM, <bradnelson@google.com> wrote:

> LGTM
>
>
> http://codereview.chromium.org/4970003/diff/1/tools/cros.DEPS/DEPS
> File tools/cros.DEPS/DEPS (right):
>
> http://codereview.chromium.org/4970003/diff/1/tools/cros.DEPS/DEPS#newcode7
> tools/cros.DEPS/DEPS:7: Var("chromium_git") + "/cros.git@d4465704",
> Is that a sufficiently precise git hash, or should we do the whole
> thing?
>
>
> http://codereview.chromium.org/4970003/
>

Powered by Google App Engine
This is Rietveld 408576698