Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: bin/cbuildbot_unittest.py

Issue 4969003: Update cbuildbot.py to upload prebuilts from preflight buildbot. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Address comments by dianders Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: bin/cbuildbot_unittest.py
diff --git a/bin/cbuildbot_unittest.py b/bin/cbuildbot_unittest.py
index 979cda55d40d2a258ce75a1c1f7ccd2706b0fe10..bbda6e447143ff3fbe0a9e8a1607d90770c71098 100755
--- a/bin/cbuildbot_unittest.py
+++ b/bin/cbuildbot_unittest.py
@@ -171,10 +171,13 @@ class CBuildBotTest(mox.MoxTestBase):
m_file.read().AndReturn(self._test_string)
m_file.close()
+ drop_file = '%s/src/scripts/cbuildbot_package.list' % self._buildroot
sosa 2010/11/23 23:56:21 Can you reference the var in cbuildbot instead?
cbuildbot.RunCommand(['./cros_mark_as_stable', '--all',
'--board=%s' % self._test_board,
'--overlays=%s' % ':'.join(self._chroot_overlays),
- '--tracking_branch=cros/master', 'commit'],
+ '--tracking_branch=cros/master',
+ '--drop_file=%s' % ReinterpretPathForChroot(drop_file),
+ 'commit'],
cwd='%s/src/scripts' % self._buildroot,
enter_chroot=True)
@@ -194,10 +197,13 @@ class CBuildBotTest(mox.MoxTestBase):
m_file.read().AndReturn('None')
m_file.close()
+ drop_file = '%s/src/scripts/cbuildbot_package.list' % self._buildroot
sosa 2010/11/23 23:56:21 Same here
cbuildbot.RunCommand(['./cros_mark_as_stable', '--all',
'--board=%s' % self._test_board,
'--overlays=%s' % ':'.join(self._chroot_overlays),
- '--tracking_branch=cros/master', 'commit'],
+ '--tracking_branch=cros/master',
+ '--drop_file=%s' % ReinterpretPathForChroot(drop_file),
+ 'commit'],
cwd='%s/src/scripts' % self._buildroot,
enter_chroot=True)
@@ -207,6 +213,32 @@ class CBuildBotTest(mox.MoxTestBase):
self._overlays)
self.mox.VerifyAll()
+ def testGetPortageEnvVar(self):
sosa 2010/11/23 23:56:21 Doc string line...useful when test fails
davidjames 2010/11/24 00:29:23 Done.
+ envvar = 'EXAMPLE'
+ cbuildbot.RunCommand(mox.And(mox.IsA(list), mox.In(envvar)),
+ cwd='%s/src/scripts' % self._buildroot,
+ redirect_stdout=True, enter_chroot=True,
+ error_ok=True).AndReturn('RESULT\n')
+ self.mox.ReplayAll()
+ result = cbuildbot._GetPortageEnvVar(self._buildroot, self._test_board,
+ envvar)
+ self.mox.VerifyAll()
+ self.assertEqual(result, 'RESULT')
+
+ def testUploadPublicPrebuilts(self):
sosa 2010/11/23 23:56:21 Doc string line...useful when test fails
davidjames 2010/11/24 00:29:23 Done.
+ check = mox.And(mox.IsA(list), mox.In('gs://chromeos-prebuilt'))
+ cbuildbot.RunCommand(check)
+ self.mox.ReplayAll()
+ cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'public')
+ self.mox.VerifyAll()
+
+ def testUploadPrivatePrebuilts(self):
sosa 2010/11/23 23:56:21 Doc string line...useful when test fails
davidjames 2010/11/24 00:29:23 Done.
+ check = mox.And(mox.IsA(list), mox.In('chromeos-images:/var/www/prebuilt/'))
+ cbuildbot.RunCommand(check)
+ self.mox.ReplayAll()
+ cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'private')
+ self.mox.VerifyAll()
+
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698