Issue 4967005: No persisted device id/token for unmanaged devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4967005: No persisted device id/token for unmanaged devices (Closed)

Created:
10 years, 1 month ago by Jakob Kummerow (corp)

Modified:
9 years, 7 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, danno, gfeher

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

No persisted device id/token for unmanaged devices BUG=62476 TEST=unit_tests: DeviceTokenFetcherTest.UnmanagedDevice Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66440

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -1 line)			Patch
M	chrome/browser/policy/device_token_fetcher.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/policy/device_token_fetcher_unittest.cc	View	2 chunks	+16 lines, -0 lines	2 comments	Download
M	chrome/browser/policy/mock_device_management_backend.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/mock_device_management_backend.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM with a nit. http://codereview.chromium.org/4967005/diff/1/chrome/browser/policy/device_token_fetcher_unittest.cc File chrome/browser/policy/device_token_fetcher_unittest.cc (right): http://codereview.chromium.org/4967005/diff/1/chrome/browser/policy/device_token_fetcher_unittest.cc#newcode70 chrome/browser/policy/device_token_fetcher_unittest.cc:70: std::string device_id(const DeviceTokenFetcher* fetcher) { ...

10 years, 1 month ago (2010-11-16 18:17:40 UTC) #2

Jakob Kummerow (corp)

10 years, 1 month ago (2010-11-17 10:35:02 UTC) #3

fixed nit; moved danno from reviewers to CC.

http://codereview.chromium.org/4967005/diff/1/chrome/browser/policy/device_to...
File chrome/browser/policy/device_token_fetcher_unittest.cc (right):

http://codereview.chromium.org/4967005/diff/1/chrome/browser/policy/device_to...
chrome/browser/policy/device_token_fetcher_unittest.cc:70: std::string
device_id(const DeviceTokenFetcher* fetcher) {
On 2010/11/16 18:17:40, Mattias Nissler wrote:
> const ref return value

Done.

Expand Messages | Collapse Messages