net/ftp/ftp_directory_listing_buffer_unittest.cc - Issue 4967001: FTP: improve character encoding detection in cases where ICU's first guess is wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_buffer_unittest.cc

Issue 4967001: FTP: improve character encoding detection in cases where ICU's first guess is wrong. (Closed)

Patch Set: now with tests Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_directory_listing_buffer_unittest.cc

diff --git a/net/ftp/ftp_directory_listing_buffer_unittest.cc b/net/ftp/ftp_directory_listing_buffer_unittest.cc

index 683e2f7c083ce0f3971ce7410b72f0b74b4b4e6b..ceddfc4ed75fa74f44a1f7f713cfa68c982ad497 100644

--- a/net/ftp/ftp_directory_listing_buffer_unittest.cc

+++ b/net/ftp/ftp_directory_listing_buffer_unittest.cc

@@ -42,6 +42,9 @@ TEST(FtpDirectoryListingBufferTest, Parse) {

"dir-listing-ls-17",

"dir-listing-ls-18",

"dir-listing-ls-19",

+ "dir-listing-ls-20", // TODO(phajdan.jr): should use windows-1251 encoding.

+ "dir-listing-ls-21", // TODO(phajdan.jr): should use windows-1251 encoding.

+ "dir-listing-ls-22", // TODO(phajdan.jr): should use windows-1251 encoding.

"dir-listing-mlsd-1",

"dir-listing-mlsd-2",

"dir-listing-netware-1",