Don't register gmail users at the device management server

chrome/browser/policy/device_management_policy_provider_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/net/gaia/token_service.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/policy/device_management_policy_provider.h"
 #include "chrome/browser/policy/mock_configuration_policy_store.h"
 #include "chrome/browser/policy/mock_device_management_backend.h"
 #include "chrome/common/net/gaia/gaia_constants.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/policy_constants.h"
 #include "chrome/test/mock_notification_observer.h"
+#include "chrome/test/testing_device_token_fetcher.h"
+#include "chrome/test/testing_profile.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 const char kTestToken[] = "device_policy_provider_test_auth_token";
 
 namespace policy {
 
 using ::testing::_;
 using ::testing::Mock;
 
 class DeviceManagementPolicyProviderTest : public testing::Test {
  public:
   DeviceManagementPolicyProviderTest()
       : ui_thread_(BrowserThread::UI, &loop_),
         file_thread_(BrowserThread::FILE, &loop_) {}
 
   virtual ~DeviceManagementPolicyProviderTest() {}
 
   virtual void SetUp() {
     EXPECT_TRUE(storage_dir_.CreateUniqueTempDir());
+    profile_.reset(new TestingProfile);
     CreateNewBackend();
     CreateNewProvider();
   }
 
   void CreateNewBackend() {
     backend_ = new MockDeviceManagementBackend;
     backend_->AddBooleanPolicy(key::kDisableSpdy, true);
   }
 
   void CreateNewProvider() {
-    token_service_.reset(new TokenService);
     provider_.reset(new DeviceManagementPolicyProvider(
         ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
         backend_,
-        token_service_.get(),
-        storage_dir_.path()));
+        profile_.get(),
+        new TestingDeviceTokenFetcher(backend_,
+                                      profile_.get(),
+                                      storage_dir_.path())));
     loop_.RunAllPending();
   }
 
   void SimulateSuccessfulLoginAndRunPending() {
     loop_.RunAllPending();
-    token_service_->IssueAuthTokenForTest(
+    profile_->GetTokenService()->IssueAuthTokenForTest(
         GaiaConstants::kDeviceManagementService, kTestToken);
+    TestingDeviceTokenFetcher* fetcher =
+        static_cast<TestingDeviceTokenFetcher*> (

[Mattias Nissler (ping if slow), 2010/11/22 20:36:08]

No space before (

[gfeher, 2010/11/23 13:47:51]

Done.

+            provider_->token_fetcher_.get());
+    fetcher->SimulateLogin(kTestDasherDomainUsername);
     loop_.RunAllPending();
   }
 
   void SimulateSuccessfulInitialPolicyFetch() {
     MockConfigurationPolicyStore store;
     backend_->AllShouldSucceed();
     EXPECT_CALL(*backend_, ProcessRegisterRequest(_, _, _, _)).Times(1);
     EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _)).Times(1);
     SimulateSuccessfulLoginAndRunPending();
     EXPECT_CALL(store, Apply(kPolicyDisableSpdy, _)).Times(1);
     provider_->Provide(&store);
     ASSERT_EQ(1U, store.policy_map().size());
     Mock::VerifyAndClearExpectations(backend_);
     Mock::VerifyAndClearExpectations(&store);
   }
 
   virtual void TearDown() {
     loop_.RunAllPending();
   }
 
  protected:
   MockDeviceManagementBackend* backend_;  // weak
   scoped_ptr<DeviceManagementPolicyProvider> provider_;
 
  private:
   MessageLoop loop_;
   BrowserThread ui_thread_;
   BrowserThread file_thread_;
   ScopedTempDir storage_dir_;
-  scoped_ptr<TokenService> token_service_;
+  scoped_ptr<Profile> profile_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceManagementPolicyProviderTest);
 };
 
 // If there's no login and no previously-fetched policy, the provider should
 // provide an empty policy.
 TEST_F(DeviceManagementPolicyProviderTest, InitialProvideNoLogin) {
   MockConfigurationPolicyStore store;
   backend_->AllShouldSucceed();
   EXPECT_CALL(store, Apply(_, _)).Times(0);
@@ skipping 21 matching lines @@
   EXPECT_TRUE(store.policy_map().empty());
 }
 
 // If a policy has been fetched previously, if should be available even before
 // the login succeeds or the device management backend is available.
 TEST_F(DeviceManagementPolicyProviderTest, SecondProvide) {
   // Pre-fetch and persist a policy
   SimulateSuccessfulInitialPolicyFetch();
 
   // Simulate a app relaunch by constructing a new provider. Policy should be
   // immediately provided and no refresh should be triggered.

[gfeher, 2010/11/22 16:05:51]

There is a logic change here, because the TestingProfile and the TokenService
gets reused now.

[Mattias Nissler (ping if slow), 2010/11/22 20:36:08]

Can we just reinitialize everything, i.e. the profile, the provider and the
fetcher at this point?

[gfeher, 2010/11/23 13:47:51]

No changes made, as discussed.

   CreateNewBackend();
   EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _)).Times(0);
   CreateNewProvider();
   MockConfigurationPolicyStore store;
   EXPECT_CALL(store, Apply(kPolicyDisableSpdy, _)).Times(1);
   provider_->Provide(&store);
 }
 
 // When policy is successfully fetched from the device management server, it
 // should force a policy refresh.
 TEST_F(DeviceManagementPolicyProviderTest, FetchTriggersRefresh) {
   MockNotificationObserver observer;
   NotificationRegistrar registrar;
   registrar.Add(&observer,
                 NotificationType::POLICY_CHANGED,
                 NotificationService::AllSources());
   EXPECT_CALL(observer,
               Observe(_, _, _)).Times(1);
   SimulateSuccessfulInitialPolicyFetch();
 }
 
 }