Don't register gmail users at the device management server

chrome/browser/policy/device_token_fetcher.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_DEVICE_TOKEN_FETCHER_H_
 #define CHROME_BROWSER_POLICY_DEVICE_TOKEN_FETCHER_H_
 #pragma once
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/ref_counted.h"
 #include "base/waitable_event.h"
 #include "chrome/browser/policy/device_management_backend.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
 
+class Profile;
+
 namespace policy {
 
 namespace em = enterprise_management;
 
 // Fetches the device token that can be used for policy requests with the device
 // management server, either from disk if it already has been successfully
 // requested, otherwise from the device management server. An instance of the
 // fetcher is shared as a singleton by all users of the device management token
 // to ensure they all get the same token.
 class DeviceTokenFetcher
@@ skipping 34 matching lines @@
   std::string GetDeviceToken();
 
   // True if the fetcher has a valid AuthToken for the device management server.
   bool HasAuthToken() const { return !auth_token_.empty(); }
 
   // True if the device token has been fetched and is valid.
   bool IsTokenValid() const;
 
  private:
   friend class DeviceTokenFetcherTest;
+  friend void SimulateUsernameAvailable(DeviceTokenFetcher* fetcher,
+                                        const std::string& username);
 
   // The different states that the fetcher can be in during the process of
   // getting the device token.
   enum FetcherState {
     kStateNotStarted,
     kStateLoadDeviceTokenFromDisk,
     kStateReadyToRequestDeviceTokenFromServer,
     kStateRequestingDeviceTokenFromServer,
     kStateHasDeviceToken,
     kStateFailure
@@ skipping 11 matching lines @@
   // thread.
   void AttemptTokenLoadFromDisk();
 
   // Called if it's not possible to load the device token from disk.  Sets the
   // fetcher in a state that's ready to register the device with the device
   // management server and receive the device token in return. If the AuthToken
   // for the device management server is available, initiate the server
   // request.
   void MakeReadyToRequestDeviceToken();
 
+  // Returns the email address of the currently logged-in user.
+  std::string GetCurrentUser();
+
+  // Checks the email of the currently logged-in user against the list of
+  // non-domain names. Returns false if there is no user logged in, or if the
+  // domain part of the email of the currently logged in user is in
+  // |kNonDasherDomains|.

[Mattias Nissler (ping if slow), 2010/11/16 09:54:31]

I feel the reference to |kNonDasherDomains| here is not useful, since that's an
implementation detail.

[gfeher, 2010/11/16 17:37:01]

Done.

+  bool CanCurrentUserBeDasher();
+
   // Issues a registration request to the server if both the fetcher is in the
   // ready-to-request state and the device management server AuthToken is
   // available.
   void SendServerRequestIfPossible();
 
   // Saves the device management token to disk once it has been retrieved from
   // the server. Must be called on the FILE thread.
   static void WriteDeviceTokenToDisk(const FilePath& path,
                                      const std::string& token);
 
@@ skipping 10 matching lines @@
   // AuthToken hasn't been issued yet or that was an error getting the
   // AuthToken.
   std::string auth_token_;
 
   // An event that is signaled only once the device token has been fetched
   // or it has been determined that there was an error during fetching.
   base::WaitableEvent device_token_load_complete_event_;
 
   // Registers the fetcher for notification of successful Gaia logins.
   NotificationRegistrar registrar_;
+
+  // Only set when a user is signed in via SigninManager. Only used to
+  // check later if the user is still logged on.
+  Profile* profile_;
+
+  // Helper for testing:  if this is not NULL, then DeviceTokenFetcher does not
+  // get the logged-in user's name from UserManager or SigninManager, but
+  // uses this value instead.
+  scoped_ptr<std::string> injected_username;

[Mattias Nissler (ping if slow), 2010/11/16 09:54:31]

Why scoped_ptr-wrapped?

Also, it seems a bit odd to me to effectively have a separate implementation for
tests?

[gfeher, 2010/11/16 17:37:01]

To allow it to be NULL. Let's forget it. :)
Done.

 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_DEVICE_TOKEN_FETCHER_H_