Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/extensions/extensions_service.cc

Issue 4957005: Move themes garbage-collection out of shutdown code. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Addressed asargent's comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/themes/browser_theme_provider.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extensions_service.h" 5 #include "chrome/browser/extensions/extensions_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/file_util.h" 11 #include "base/file_util.h"
12 #include "base/metrics/histogram.h" 12 #include "base/metrics/histogram.h"
13 #include "base/stl_util-inl.h" 13 #include "base/stl_util-inl.h"
14 #include "base/string16.h" 14 #include "base/string16.h"
15 #include "base/string_number_conversions.h" 15 #include "base/string_number_conversions.h"
16 #include "base/string_util.h" 16 #include "base/string_util.h"
17 #include "base/stringprintf.h" 17 #include "base/stringprintf.h"
18 #include "base/thread_restrictions.h" 18 #include "base/thread_restrictions.h"
19 #include "base/time.h" 19 #include "base/time.h"
20 #include "base/utf_string_conversions.h" 20 #include "base/utf_string_conversions.h"
21 #include "base/values.h" 21 #include "base/values.h"
22 #include "base/version.h" 22 #include "base/version.h"
23 #include "chrome/browser/browser_process.h" 23 #include "chrome/browser/browser_process.h"
24 #include "chrome/browser/themes/browser_theme_provider.h"
24 #include "chrome/browser/browser_thread.h" 25 #include "chrome/browser/browser_thread.h"
25 #include "chrome/browser/debugger/devtools_manager.h" 26 #include "chrome/browser/debugger/devtools_manager.h"
26 #include "chrome/browser/dom_ui/shown_sections_handler.h" 27 #include "chrome/browser/dom_ui/shown_sections_handler.h"
27 #include "chrome/browser/extensions/crx_installer.h" 28 #include "chrome/browser/extensions/crx_installer.h"
28 #include "chrome/browser/extensions/default_apps.h" 29 #include "chrome/browser/extensions/default_apps.h"
29 #include "chrome/browser/extensions/extension_accessibility_api.h" 30 #include "chrome/browser/extensions/extension_accessibility_api.h"
30 #include "chrome/browser/extensions/extension_bookmarks_module.h" 31 #include "chrome/browser/extensions/extension_bookmarks_module.h"
31 #include "chrome/browser/extensions/extension_browser_event_router.h" 32 #include "chrome/browser/extensions/extension_browser_event_router.h"
32 #include "chrome/browser/extensions/extension_cookies_api.h" 33 #include "chrome/browser/extensions/extension_cookies_api.h"
33 #include "chrome/browser/extensions/extension_data_deleter.h" 34 #include "chrome/browser/extensions/extension_data_deleter.h"
(...skipping 1419 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 1454
1454 std::map<std::string, FilePath> extension_paths; 1455 std::map<std::string, FilePath> extension_paths;
1455 for (size_t i = 0; i < info->size(); ++i) 1456 for (size_t i = 0; i < info->size(); ++i)
1456 extension_paths[info->at(i)->extension_id] = info->at(i)->extension_path; 1457 extension_paths[info->at(i)->extension_id] = info->at(i)->extension_path;
1457 1458
1458 BrowserThread::PostTask( 1459 BrowserThread::PostTask(
1459 BrowserThread::FILE, FROM_HERE, 1460 BrowserThread::FILE, FROM_HERE,
1460 NewRunnableFunction( 1461 NewRunnableFunction(
1461 &extension_file_util::GarbageCollectExtensions, install_directory_, 1462 &extension_file_util::GarbageCollectExtensions, install_directory_,
1462 extension_paths)); 1463 extension_paths));
1464
1465 // Also garbage-collect themes. We check |profile_| to be
1466 // defensive; in the future, we may call GarbageCollectExtensions()
1467 // from somewhere other than Init() (e.g., in a timer).
1468 if (profile_) {
1469 profile_->GetThemeProvider()->RemoveUnusedThemes();
1470 }
1463 } 1471 }
1464 1472
1465 void ExtensionsService::OnLoadedInstalledExtensions() { 1473 void ExtensionsService::OnLoadedInstalledExtensions() {
1466 ready_ = true; 1474 ready_ = true;
1467 if (updater_.get()) { 1475 if (updater_.get()) {
1468 updater_->Start(); 1476 updater_->Start();
1469 } 1477 }
1470 NotificationService::current()->Notify( 1478 NotificationService::current()->Notify(
1471 NotificationType::EXTENSIONS_READY, 1479 NotificationType::EXTENSIONS_READY,
1472 Source<Profile>(profile_), 1480 Source<Profile>(profile_),
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
1942 } 1950 }
1943 1951
1944 bool ExtensionsService::IsBeingUpgraded(const Extension* extension) { 1952 bool ExtensionsService::IsBeingUpgraded(const Extension* extension) {
1945 return extension_runtime_data_[extension->id()].being_upgraded; 1953 return extension_runtime_data_[extension->id()].being_upgraded;
1946 } 1954 }
1947 1955
1948 void ExtensionsService::SetBeingUpgraded(const Extension* extension, 1956 void ExtensionsService::SetBeingUpgraded(const Extension* extension,
1949 bool value) { 1957 bool value) {
1950 extension_runtime_data_[extension->id()].being_upgraded = value; 1958 extension_runtime_data_[extension->id()].being_upgraded = value;
1951 } 1959 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/themes/browser_theme_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698