- Check for a NULL PluginObject at all NPAPI entry points. This fixes a crash in Chrome where ...

- Check for a NULL PluginObject at all NPAPI entry points. This fixes a crash in Chrome where the browser foolishly calls NPP_SetWindow with instance->pdata == NULL.
- Factor out obscene amounts of redundancy from main_<platform>.(cc|mm) into main.cc. This makes no change to the functionality, except that NP_Initialize on Linux now has HANDLE_CRASHES whereas before it did not.

TEST=built on Linux, Mac, and Windows; installed and loaded O3D on each platform and made sure it worked; repeatedly loaded on Mac & Win in Chrome 8.0.552.200 and verified no crashes; inspected "svn diff" output manually and verified that the code and order of execution of that code is unchanded for each platform
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66344

[Tim H, 2010-11-16 23:03:23]

LGTM

http://codereview.chromium.org/4957002/diff/27001/plugin/cross/plugin_logging.h
File plugin/cross/plugin_logging.h (right):

http://codereview.chromium.org/4957002/diff/27001/plugin/cross/plugin_logging...
plugin/cross/plugin_logging.h:41: #include "statsreport/metrics.h"
Necessary?  Don't see any other changes in this file.

[Tristan Schmelcher 2, 2010-11-16 23:05:44]

http://codereview.chromium.org/4957002/diff/27001/plugin/cross/plugin_logging.h
File plugin/cross/plugin_logging.h (right):

http://codereview.chromium.org/4957002/diff/27001/plugin/cross/plugin_logging...
plugin/cross/plugin_logging.h:41: #include "statsreport/metrics.h"
On 2010/11/16 23:03:23, thaloun wrote:
> Necessary?  Don't see any other changes in this file.

Yeah, it's necessary. This file uses a structure defined in that header but
didn't include it. It only worked before because that header happened to be
included in one of the many main* files before this one is included. Now that I
have cleaned up those files, this one needs the include.

[Tristan Schmelcher 2, 2010-11-17 00:23:00]

It looks like this may not fully fix the issue, at least on Mac, but it is
certainly an improvement and all of the changes are desirable regardless, so I'm
going to submit now and investigate further.