Move more extensions hard coded error messages to .grd file....

Move more extensions hard coded error messages to .grd file.

BUG=51398
TEST=compiles.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69914

[laurum, 2010-11-13 15:21:06]

Hello,

I have created a patch for issue http://crbug.com/51398 .
Please review and let me know if there is still some issues.

Best regards,
Lauri Oherd

[Aaron Boodman, 2010-11-13 20:03:13]

Thank you for the patch!

Looking at this, I realize that it's a bit wasteful to translate all these
detailed technical error messages. Also part of them are developer errors (crx
has invalid structure), which don't really need to be translated because the
extension SDK itself is English.

I think we really only need four translated error messages in
generated_resources.grd:

1. The exact message you have now from IDS_EXTENSION_UNPACK_FAILED. Use this one
just as you have it now. This one happens often and it's something that
knowledgeable users could fix themselves. So I think it's useful to have it
translated.

2. Package is invalid. Details: %ERROR_MESSAGE%. Use this one in the case where
we currently have ReportFailure(error), that is in the cases where we get an
error message string back from some other component. The message might be in
English, but these are typically developer errors, and the extension SDK is
English, so I think this is OK.

3. Package is invalid: %ERROR_CODE%. Use this one in cases where we fail to
install the extension because the crx file is invalid. For example, because the
crx header or signature is invalid. For each of these error messages, create a
unique "error code", like this: CRX_HEADER_INVALID or
CRX_VERSION_NUMBER_INVALID. The error codes will be English, but they are
obviously codes so I think this is acceptable, and I think this is more
obviously useful than a numeric code.

4. Could not install package: %ERROR_CODE%. Use this one in the cases where we
fail to install because of some problem with the filesystem (except for the one
case covered by 1, above). For each of these errors, create an error code like
COULD_NOT_CREATE_TEMP_DIRECTORY.

See any of the strings in generated_resources.grd that contain '<ph' for an
example of how to create messages with placeholders. Find the place where these
messages are used in the code to see an example of how to fill in the
placeholders.

[laurum, 2010-11-18 22:23:09]

Thank you for the thorough review!
I have updated the patch according to suggestions.

On 2010/11/13 20:03:13, Aaron Boodman wrote:
> Thank you for the patch!
> 
> Looking at this, I realize that it's a bit wasteful to translate all these
> detailed technical error messages. Also part of them are developer errors (crx
> has invalid structure), which don't really need to be translated because the
> extension SDK itself is English.
> 
> I think we really only need four translated error messages in
> generated_resources.grd:
> 
> 1. The exact message you have now from IDS_EXTENSION_UNPACK_FAILED. Use this
one
> just as you have it now. This one happens often and it's something that
> knowledgeable users could fix themselves. So I think it's useful to have it
> translated.
> 
> 2. Package is invalid. Details: %ERROR_MESSAGE%. Use this one in the case
where
> we currently have ReportFailure(error), that is in the cases where we get an
> error message string back from some other component. The message might be in
> English, but these are typically developer errors, and the extension SDK is
> English, so I think this is OK.
> 
> 3. Package is invalid: %ERROR_CODE%. Use this one in cases where we fail to
> install the extension because the crx file is invalid. For example, because
the
> crx header or signature is invalid. For each of these error messages, create a
> unique "error code", like this: CRX_HEADER_INVALID or
> CRX_VERSION_NUMBER_INVALID. The error codes will be English, but they are
> obviously codes so I think this is acceptable, and I think this is more
> obviously useful than a numeric code.
> 
> 4. Could not install package: %ERROR_CODE%. Use this one in the cases where we
> fail to install because of some problem with the filesystem (except for the
one
> case covered by 1, above). For each of these errors, create an error code like
> COULD_NOT_CREATE_TEMP_DIRECTORY.
> 
> See any of the strings in generated_resources.grd that contain '<ph' for an
> example of how to create messages with placeholders. Find the place where
these
> messages are used in the code to see an example of how to fill in the
> placeholders.

[laurum, 2010-11-27 20:32:20]

Hi Aaron, could you review this to me?
Thanks!

[Aaron Boodman, 2010-12-07 00:09:11]

Sorry for the long delay. This looks great, landing now...

Make sure to complete http://code.google.com/legal/individual-cla-v1.0.html if
you haven't already.

[laurum, 2010-12-07 05:56:55]

Thank you! I have completed
http://code.google.com/legal/individual-cla-v1.0.html form.

[tfarina, 2010-12-21 12:43:57]

On 2010/12/07 05:56:55, laurum wrote:
> Thank you! I have completed
> http://code.google.com/legal/individual-cla-v1.0.html form.

This patch doesn't apply anymore. Could you rebase it to ToT and upload it
again?

Thanks.

[tfarina, 2010-12-22 00:16:13]

On 2010/12/21 12:43:57, tfarina wrote:
> On 2010/12/07 05:56:55, laurum wrote:
> > Thank you! I have completed
> > http://code.google.com/legal/individual-cla-v1.0.html form.
> 
> This patch doesn't apply anymore. Could you rebase it to ToT and upload it
> again?
> 
> Thanks.

After patching the sandboxed_extension_unpacker.cc line by line due to the
conflicts, I uploaded it here http://codereview.chromium.org/6088002/. I will
commit when the trybots passes.

[tfarina, 2010-12-22 11:30:47]

Landed, thanks.