Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: chrome/browser/cocoa/tab_window_controller.mm

Issue 495010: Mac: fix/implement app windows (not app mode), popups, drawing; refactor code. (Closed)
Patch Set: Updated per pink's review. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/tab_window_controller.h ('k') | chrome/browser/cocoa/toolbar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_window_controller.mm
diff --git a/chrome/browser/cocoa/tab_window_controller.mm b/chrome/browser/cocoa/tab_window_controller.mm
index c8e881c1137b3c011e71d917af996ac1748c712e..984ab35f82f4248d42cf7c5df2baa014a42fdb61 100644
--- a/chrome/browser/cocoa/tab_window_controller.mm
+++ b/chrome/browser/cocoa/tab_window_controller.mm
@@ -23,7 +23,7 @@
}
- (void)windowDidLoad {
- if ([self isNormalWindow]) {
+ if ([self hasTabStrip]) {
// Place the tab bar above the content box and add it to the view hierarchy
// as a sibling of the content view so it can overlap with the window frame.
NSRect tabFrame = [tabContentArea_ frame];
@@ -199,8 +199,8 @@
return @"";
}
-- (BOOL)isNormalWindow {
- // subclass must implement
+- (BOOL)hasTabStrip {
+ // Subclasses should implement this.
NOTIMPLEMENTED();
return YES;
}
« no previous file with comments | « chrome/browser/cocoa/tab_window_controller.h ('k') | chrome/browser/cocoa/toolbar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698