chrome/browser/cocoa/chrome_browser_window.mm - Issue 495010: Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/chrome_browser_window.mm

Issue 495010: Mac: fix/implement app windows (not app mode), popups, drawing; refactor code. (Closed)

Patch Set: Updated per pink's review. Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/chrome_browser_window.mm

diff --git a/chrome/browser/cocoa/chrome_browser_window.mm b/chrome/browser/cocoa/chrome_browser_window.mm

index c4b503b167f2b3f8cfa5ef0f21287b10b71ce609..1030bc86bd84c9ad04eed6383eb10a99ee38fe4c 100644

--- a/chrome/browser/cocoa/chrome_browser_window.mm

+++ b/chrome/browser/cocoa/chrome_browser_window.mm

@@ -112,7 +112,7 @@ namespace {

closeButton_ = [NSWindow standardWindowButton:NSWindowCloseButton

forStyleMask:aStyle];

NSRect closeButtonFrame = [closeButton_ frame];

- CGFloat yOffset = [browserController isNormalWindow] ?

+ CGFloat yOffset = [browserController hasTabStrip] ?

kChromeWindowButtonsWithTabStripOffsetFromTop :

kChromeWindowButtonsWithoutTabStripOffsetFromTop;

closeButtonFrame.origin =