Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.

chrome/browser/cocoa/download_item_cell.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/download_item_cell.h"
 
 #include "app/gfx/canvas_paint.h"
 #include "app/gfx/text_elider.h"
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
@@ skipping 379 matching lines @@
     bgGradient = [theme gradientForStyle:GTMThemeStyleToolBarButton
                                    state:active];
   }
 
   NSRect buttonDrawRect, dropdownDrawRect;
   NSDivideRect(drawFrame, &dropdownDrawRect, &buttonDrawRect,
       kDropdownAreaWidth, NSMaxXEdge);
 
   NSBezierPath* buttonInnerPath = [self
       leftRoundedPath:radius inRect:buttonDrawRect];
-  NSBezierPath* buttonOuterPath = [self
-      leftRoundedPath:(radius + 1)
-               inRect:NSInsetRect(buttonDrawRect, -1, -1)];
-
   NSBezierPath* dropdownInnerPath = [self
       rightRoundedPath:radius inRect:dropdownDrawRect];
-  NSBezierPath* dropdownOuterPath = [self
-      rightRoundedPath:(radius + 1)
-                inRect:NSInsetRect(dropdownDrawRect, -1, -1)];
 
   // Stroke the borders and appropriate fill gradient.
   [self drawBorderAndFillForTheme:theme
                       controlView:controlView
-                        outerPath:buttonOuterPath
                         innerPath:buttonInnerPath
               showClickedGradient:[self isButtonPartPressed]
             showHighlightGradient:[self isMouseOverButtonPart]
                        hoverAlpha:0.0
                            active:active
                         cellFrame:cellFrame
                   defaultGradient:bgGradient];
 
   [self drawBorderAndFillForTheme:theme
                       controlView:controlView
-                        outerPath:dropdownOuterPath
                         innerPath:dropdownInnerPath
               showClickedGradient:[self isDropdownPartPressed]
             showHighlightGradient:[self isMouseOverDropdownPart]
                        hoverAlpha:0.0
                            active:active
                         cellFrame:cellFrame
                   defaultGradient:bgGradient];
 
   [self drawInteriorWithFrame:innerFrame inView:controlView];
 }
@@ skipping 180 matching lines @@
   }
   return self;
 }
 
 - (void)setCurrentProgress:(NSAnimationProgress)progress {
   [super setCurrentProgress:progress];
   [cell_ animation:self progressed:progress];
 }
 
 @end