Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.

chrome/browser/cocoa/bookmark_bar_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util_mac.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_editor.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ skipping 434 matching lines @@
 }
 
 // We don't change a preference; we only change visibility. Preference changing
 // (global state) is handled in |BrowserWindowCocoa::ToggleBookmarkBar()|. We
 // simply update based on what we're told.
 - (void)updateVisibility {
   [self showBookmarkBarWithAnimation:NO];
 }
 
 - (void)setBookmarkBarEnabled:(BOOL)enabled {
-  barIsEnabled_ = enabled;
-  [self updateVisibility];
+  if (enabled != barIsEnabled_) {
+    barIsEnabled_ = enabled;
+    [self updateVisibility];
+  }
 }
 
 - (CGFloat)getDesiredToolbarHeightCompression {
   // Some special cases....
   if (!barIsEnabled_)
     return 0;
 
   if ([self isAnimationRunning]) {
     // No toolbar compression when animating between hidden and showing, nor
     // between showing and detached.
@@ skipping 1037 matching lines @@
     [pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]
                owner:nil];
     [pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]
             forType:kBookmarkButtonDragType];
   } else {
     NOTREACHED();
   }
 }
 
 @end