Issue 495008: wm: Include breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495008: wm: Include breakpad. (Closed)

Created:
11 years ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

wm: Include breakpad. We just write minidumps to /home/chronos for now -- I'm deferring agreeing on a central location for them and actually uploading them for later. BUG=47

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -2 lines)			Patch
M	src/platform/window_manager/SConstruct	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/platform/window_manager/main.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/scripts/build_platform_packages.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
A	src/third_party/google-breakpad/make_pkg.sh	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

On 2009/12/12 03:12:54, Daniel Erat wrote: > Can you put in a to-do for rate-limiting ...

11 years ago (2009-12-12 22:56:04 UTC) #2

Chris Masone

11 years ago (2009-12-12 22:58:24 UTC) #3

On 2009/12/12 22:56:04, cmasone wrote:
> On 2009/12/12 03:12:54, Daniel Erat wrote:
> > 
> 
> Can you put in a to-do for rate-limiting crash dumps.  When we put in
uploading,
> we need to have rate limiting.  That's what the whole FilterCallback I put
into
> slim is for; I think that's the right way to do it, but I'm not totally
> positive.

Also, LGTM after the TODO

Expand Messages | Collapse Messages