AU: missing file in last commit

AU: missing file in last commit

[adlr, 2009-12-12 00:26:59]

Sorry, forgot a file

[Daniel Erat, 2009-12-12 02:18:00]

http://codereview.chromium.org/495005/diff/1/2
File src/platform/update_engine/test_installer_main.cc (right):

http://codereview.chromium.org/495005/diff/1/2#newcode72
src/platform/update_engine/test_installer_main.cc:72:
ObjectFeederAction<InstallPlan>* object_feeder_action =
make these shared_ptrs

http://codereview.chromium.org/495005/diff/1/2#newcode128
src/platform/update_engine/test_installer_main.cc:128: bool Main(int argc,
char** argv) {
what's the reason for splitting this out from main()?  just for the namespace?

http://codereview.chromium.org/495005/diff/1/2#newcode138
src/platform/update_engine/test_installer_main.cc:138: if
(!FLAGS_dump_delta.empty()) {
should probably check that all the other flags are empty inside of this 'if'
block

http://codereview.chromium.org/495005/diff/1/2#newcode140
src/platform/update_engine/test_installer_main.cc:140: DeltaDiffParser::Iterator
it = parser.Begin();
why not initialize this in the for loop?

http://codereview.chromium.org/495005/diff/1/2#newcode179
src/platform/update_engine/test_installer_main.cc:179: GMainLoop *loop =
g_main_loop_new(g_main_context_default(), FALSE);
fix '*' spacing

[adlr, 2009-12-15 23:39:51]

http://codereview.chromium.org/495005/diff/1/2
File src/platform/update_engine/test_installer_main.cc (right):

http://codereview.chromium.org/495005/diff/1/2#newcode72
src/platform/update_engine/test_installer_main.cc:72:
ObjectFeederAction<InstallPlan>* object_feeder_action =
On 2009/12/12 02:18:00, Daniel Erat wrote:
> make these shared_ptrs

Done.

http://codereview.chromium.org/495005/diff/1/2#newcode128
src/platform/update_engine/test_installer_main.cc:128: bool Main(int argc,
char** argv) {
On 2009/12/12 02:18:00, Daniel Erat wrote:
> what's the reason for splitting this out from main()?  just for the namespace?

yeah, namespace

http://codereview.chromium.org/495005/diff/1/2#newcode138
src/platform/update_engine/test_installer_main.cc:138: if
(!FLAGS_dump_delta.empty()) {
On 2009/12/12 02:18:00, Daniel Erat wrote:
> should probably check that all the other flags are empty inside of this 'if'
> block

Done.

http://codereview.chromium.org/495005/diff/1/2#newcode140
src/platform/update_engine/test_installer_main.cc:140: DeltaDiffParser::Iterator
it = parser.Begin();
On 2009/12/12 02:18:00, Daniel Erat wrote:
> why not initialize this in the for loop?

Done.

http://codereview.chromium.org/495005/diff/1/2#newcode179
src/platform/update_engine/test_installer_main.cc:179: GMainLoop *loop =
g_main_loop_new(g_main_context_default(), FALSE);
On 2009/12/12 02:18:00, Daniel Erat wrote:
> fix '*' spacing

Done.

[Daniel Erat, 2009-12-15 23:57:49]

LGTM

http://codereview.chromium.org/495005/diff/5001/5002
File src/platform/update_engine/test_installer_main.cc (right):

http://codereview.chromium.org/495005/diff/5001/5002#newcode107
src/platform/update_engine/test_installer_main.cc:107: LOG(INFO) << "install
succeeded";
nit:

  LOG(INFO) << "install " << (success ? "succeeded" : "failed");

is shorter