Add a unit test for CommandLine that makes sure that GetProgram will not retu...

base/command_line_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 161 matching lines @@
   c1.AppendSwitch("switch1");
   CommandLine c2(FilePath(FILE_PATH_LITERAL("Program2")));
   c2.AppendSwitch("switch2");
 
   c1.AppendArguments(c2, true);
   EXPECT_EQ(c1.GetProgram().value(), c2.GetProgram().value());
   EXPECT_TRUE(c1.HasSwitch("switch1"));
   EXPECT_TRUE(c1.HasSwitch("switch2"));
 }
 
+#if defined(OS_WIN)
+// Make sure that the program part of a command line is always quoted.
+// This only makes sense on Windows and the test is basically here to guard
+// against regressions.
+TEST(CommandLineTest, ProgramQuotes) {
+  const FilePath kProgram(FILE_PATH_LITERAL("Program"));

[Evan Martin, 2010/11/29 20:39:55]

Since you're in a Windows-specific branch, L"Program" is also acceptable and
perhaps more readable. 

[tommi (sloooow) - chröme, 2010/11/29 20:45:01]

Done.

+
+  // Check that quotes are not returned from GetProgram().
+  CommandLine cl(kProgram);
+  EXPECT_EQ(kProgram.value(), cl.GetProgram().value());
+
+  // Verify that in the command line string, the program part is always quoted.
+  CommandLine::StringType cmd(cl.command_line_string());
+  CommandLine::StringType program(cl.GetProgram().value());
+  EXPECT_EQ('"', cmd[0]);
+  EXPECT_EQ(program, cmd.substr(1, program.length()));
+  EXPECT_EQ('"', cmd[program.length() + 1]);
+}
+#endif