chrome/browser/policy/proto/device_management_local.proto - Issue 4949003: CrOS policies: Store device ID with device token

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/policy/proto/device_management_local.proto

Issue 4949003: CrOS policies: Store device ID with device token (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/policy/device_token_fetcher.cc ('K') | « chrome/browser/policy/device_token_fetcher_unittest.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto2";	5 syntax = "proto2";

6	6

7 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

8	8

9 package enterprise_management;	9 package enterprise_management;

10	10

11 import "device_management_backend.proto";	11 import "device_management_backend.proto";

12	12

13 // Wrapper around DevicePolicyResponse for caching on disk.	13 // Wrapper around DevicePolicyResponse for caching on disk.

14 message CachedDevicePolicyResponse {	14 message CachedDevicePolicyResponse {

15 // The DevicePolicyResponse wrapped by this message.	15 // The DevicePolicyResponse wrapped by this message.

16 required DevicePolicyResponse policy = 1;	16 required DevicePolicyResponse policy = 1;

17 // Timestamp noting when this policy was cached.	17 // Timestamp noting when this policy was cached.

18 optional uint64 timestamp = 2;	18 optional uint64 timestamp = 2;

19 }	19 }

20	20

	21 // Encapsulates a device token and the associated device ID.
	Mattias Nissler (ping if slow) 2010/11/15 18:02:51 The comment suggests you generate a device ID for The comment suggests you generate a device ID for a token, but actually it's the other way round. Jakob Kummerow (corp) 2010/11/16 09:37:02 Done. Show quoted text On 2010/11/15 18:02:51, Mattias Nissler wrote: > The comment suggests you generate a device ID for a token, but actually it's the > other way round. Done.
	22 message DeviceToken {
	Mattias Nissler (ping if slow) 2010/11/15 18:02:51 Same for the message name here. Can we make it som Same for the message name here. Can we make it something more generic, maybe DeviceMetaData? Or DeviceIdentity? Not sure these are good choices, but DeviceToken is actually missing the ID part. Jakob Kummerow (corp) 2010/11/16 09:37:02 Done. Show quoted text On 2010/11/15 18:02:51, Mattias Nissler wrote: > Same for the message name here. Can we make it something more generic, maybe > DeviceMetaData? Or DeviceIdentity? Not sure these are good choices, but > DeviceToken is actually missing the ID part. Done.
	23 required string device_token = 1;

	24 required string device_id = 2;
	Mattias Nissler (ping if slow) 2010/11/15 18:02:51 Can we make these optional? Can we make these optional? Jakob Kummerow (corp) 2010/11/16 09:37:02 Done. Show quoted text On 2010/11/15 18:02:51, Mattias Nissler wrote: > Can we make these optional? Done.
	25 }

	26

OLD	NEW