Mac: Let browser_tests run in bundled mode for their whole lifetime.

base/mac_util.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac_util.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_path.h"
 #include "base/logging.h"
@@ skipping 127 matching lines @@
   NSString *path_string = [(NSURL *)url.get() path];
   return [path_string fileSystemRepresentation];
 }
 
 bool FSRefFromPath(const std::string& path, FSRef* ref) {
   OSStatus status = FSPathMakeRef((const UInt8*)path.c_str(),
                                   ref, nil);
   return status == noErr;
 }
 
+static bool g_override_am_i_bundled = false;
+static bool g_override_am_i_bundled_value = false;
+
 // Adapted from http://developer.apple.com/carbon/tipsandtricks.html#AmIBundled
-bool AmIBundled() {
+static bool UncachedAmIBundled() {
+  if (g_override_am_i_bundled)
+    return g_override_am_i_bundled_value;
+
   ProcessSerialNumber psn = {0, kCurrentProcess};
 
   FSRef fsref;
   OSStatus pbErr;
   if ((pbErr = GetProcessBundleLocation(&psn, &fsref)) != noErr) {
     LOG(ERROR) << "GetProcessBundleLocation failed: error " << pbErr;
     return false;
   }
 
   FSCatalogInfo info;
   OSErr fsErr;
   if ((fsErr = FSGetCatalogInfo(&fsref, kFSCatInfoNodeFlags, &info,
                                 NULL, NULL, NULL)) != noErr) {
     LOG(ERROR) << "FSGetCatalogInfo failed: error " << fsErr;
     return false;
   }
 
   return info.nodeFlags & kFSNodeIsDirectoryMask;
 }
 
+bool AmIBundled() {
+  // If the return value is not cached, this function will return different
+  // values depending on when it's called. This confuses some client code, see
+  // http://crbug.com/63183 .
+  static bool result = UncachedAmIBundled();
+  DCHECK_EQ(result, UncachedAmIBundled())
+      << "The return value of AmIBundled() changed. This will confuse tests. "
+      << "Call SetAmIBundled() override manually if your test binary "
+      << "delay-loads the framework.";
+  return result;
+}
+
+void SetOverrideAmIBundled(bool value) {
+  g_override_am_i_bundled = true;
+  g_override_am_i_bundled_value = value;
+}
+
 bool IsBackgroundOnlyProcess() {
   // This function really does want to examine NSBundle's idea of the main
   // bundle dictionary, and not the overriden MainAppBundle.  It needs to look
   // at the actual running .app's Info.plist to access its LSUIElement
   // property.
   NSDictionary* info_dictionary = [[NSBundle mainBundle] infoDictionary];
   return [[info_dictionary objectForKey:@"LSUIElement"] boolValue] != NO;
 }
 
 // No threading worries since NSBundle isn't thread safe.
@@ skipping 507 matching lines @@
   id<NSObject> nsobj = static_cast<id<NSObject> >(obj);
   [nsobj retain];
 }
 
 void NSObjectRelease(void* obj) {
   id<NSObject> nsobj = static_cast<id<NSObject> >(obj);
   [nsobj release];
 }
 
 }  // namespace mac_util