Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 4937001: Make the max_semispace_size parameter customizable on a PLATFORM basis.... (Closed)

Created:
10 years, 1 month ago by Dineel
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the max_semispace_size parameter customizable on a PLATFORM basis. This provides platforms with larger available memory pools the ability to exploit these. The current existing implementation limits the expansion of the max_semispace_size parameter to the default max value in the presence of snapshots.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/heap.cc View 1 chunk +12 lines, -3 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
LGTM, I'll land for you with minor modifications. http://codereview.chromium.org/4937001/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/4937001/diff/1/src/heap.cc#newcode101 src/heap.cc:101: #if ...
10 years, 1 month ago (2010-11-15 08:43:04 UTC) #1
Mads Ager (chromium)
http://codereview.chromium.org/4937001/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/4937001/diff/1/src/heap.cc#newcode101 src/heap.cc:101: #if defined(PLATFORM_SPECIFIC_MAX_SEMISPACE_SIZE) On 2010/11/15 08:43:04, Mads Ager wrote: > ...
10 years, 1 month ago (2010-11-15 10:00:56 UTC) #2
Mads Ager (chromium)
10 years, 1 month ago (2010-11-15 10:13:08 UTC) #3
Landed in revision 5823.

Powered by Google App Engine
This is Rietveld 408576698