net/http/http_proxy_client_socket_pool.h - Issue 4935001: Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool.h

Issue 4935001: Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Pass a ClientSocketHandle up out of the HttpProxyClientSocketPool Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_transaction_unittest.cc ('K') | « net/http/http_proxy_client_socket.cc ('k') | net/http/http_proxy_client_socket_pool.cc » ('j') | net/http/http_proxy_client_socket_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_proxy_client_socket_pool.h

===================================================================

--- net/http/http_proxy_client_socket_pool.h (revision 68959)

+++ net/http/http_proxy_client_socket_pool.h (working copy)

@@ -15,6 +15,7 @@

#include "net/base/host_port_pair.h"

#include "net/http/http_auth.h"

#include "net/http/http_response_info.h"

+#include "net/http/proxy_client_socket.h"

#include "net/socket/client_socket_pool_base.h"

#include "net/socket/client_socket_pool_histograms.h"

#include "net/socket/client_socket_pool.h"

@@ -157,7 +158,7 @@

State next_state_;

CompletionCallbackImpl<HttpProxyConnectJob> callback_;

scoped_ptr<ClientSocketHandle> transport_socket_handle_;

- scoped_ptr<ClientSocket> transport_socket_;

+ scoped_ptr<ProxyClientSocket> transport_socket_;

vandebo (ex-Chrome) 2010/12/16 02:24:31 nit: I don't think the changes in this file are re

Ryan Hamilton 2010/12/16 05:23:50 Agreed. I noticed that to. On the other hand, I

bool using_spdy_;

HttpResponseInfo error_response_info_;