Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

chrome/browser/renderer_host/resource_dispatcher_host.cc

Index: chrome/browser/renderer_host/resource_dispatcher_host.cc
===================================================================
--- chrome/browser/renderer_host/resource_dispatcher_host.cc	(revision 68026)
+++ chrome/browser/renderer_host/resource_dispatcher_host.cc	(working copy)
@@ -1572,15 +1572,6 @@
     return CertStore::GetSharedInstance()->StoreCert(request->ssl_info().cert,
                                                      child_id);
   }
-  // If there is no SSL info attached to this request, we must either be a non

[vandebo (ex-Chrome), 2010/12/04 00:30:37]

Why did this code need to go?

[Ryan Hamilton, 2010/12/09 21:19:35]

Because *any* response from a HTTPS URL (when going through an HTTPS Proxy) is
now a potentially valid response.  (That's what this CL is all about).  If there
were a way to check for the type of proxy used in this request, then we could
add a more restrictive check, but since that information is not available, we
have no choice...

-  // secure request, or the request has been canceled or failed (before the SSL
-  // info was populated), or the response is an error (we have seen 403, 404,
-  // and 501) made up by the proxy.
-  DCHECK(!request->url().SchemeIsSecure() ||
-         (request->status().status() == URLRequestStatus::CANCELED) ||
-         (request->status().status() == URLRequestStatus::FAILED) ||
-         ((request->response_headers()->response_code() >= 400) &&
-         (request->response_headers()->response_code() <= 599)));
   return 0;
 }