Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

net/http/proxy_client_socket.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_PROXY_CLIENT_SOCKET_H_
+#define NET_HTTP_PROXY_CLIENT_SOCKET_H_
+#pragma once
+
+#include "net/socket/client_socket.h"
+
+namespace net {
+
+class HttpStream;
+class HttpResponseInfo;
+
+class ProxyClientSocket : public ClientSocket {
+ public:
+  ProxyClientSocket() {}

[vandebo (ex-Chrome), 2010/12/16 02:24:31]

nit: Not needed.

[Ryan Hamilton, 2010/12/16 05:23:50]

Hm.  I just tried to remove it, but got this message:

net/spdy/spdy_proxy_client_socket.cc:48: error: no matching function for call to
‘net::ProxyClientSocket::ProxyClientSocket()’

Is this an artifact of:

DISALLOW_COPY_AND_ASSIGN(ProxyClientSocket);

+  virtual ~ProxyClientSocket() {}
+
+  // Returns the HttpResponseInfo (including HTTP Headers) from
+  // the response to the CONNECT request.
+  virtual const HttpResponseInfo* GetConnectResponseInfo() const = 0;
+
+  // Transfers ownership of a newly created HttpStream to the caller
+  // which can be used to read the response body.
+  virtual HttpStream* CreateConnectResponseStream() = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProxyClientSocket);
+};
+
+}  // namespace net
+
+#endif  // NET_HTTP_PROXY_CLIENT_SOCKET_H_