Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

net/spdy/spdy_proxy_client_socket.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_proxy_client_socket.h"
 
 #include <algorithm>  // min
 
 #include "base/logging.h"
 #include "base/string_util.h"
@@ skipping 41 matching lines @@
     request_.extra_headers.SetHeader(HttpRequestHeaders::kUserAgent,
                                      user_agent);
   spdy_stream_->SetDelegate(this);
   was_ever_used_ = spdy_stream_->WasEverUsed();
 }
 
 SpdyProxyClientSocket::~SpdyProxyClientSocket() {
   Disconnect();
 }
 
+// In the event of a non-200 response to the CONNECT request, this
+// method may be called to return an HttpStream in order to read
+// the response body.
+HttpStream* SpdyProxyClientSocket::GetConnectResponseStream() {
+  SpdyStream* stream = spdy_stream_;
+  spdy_stream_ = NULL;
+  return new SpdyHttpStream(stream);
+}
+
 // Sends a SYN_STREAM frame to the proxy with a CONNECT request
 // for the specified endpoint.  Waits for the server to send back
 // a SYN_REPLY frame.  OK will be returned if the status is 200.
 // ERR_TUNNEL_CONNECTION_FAILED will be returned for any other status.
 // In any of these cases, Read() may be called to retrieve the HTTP
 // response body.  Any other return values should be considered fatal.
 // TODO(rch): handle 407 proxy auth requested correctly, perhaps
 // by creating a new stream for the subsequent request.
 // TODO(rch): create a more appropriate error code to disambiguate
 // the HTTPS Proxy tunnel failure from an HTTP Proxy tunnel failure.
@@ skipping 276 matching lines @@
 
   next_state_ = STATE_OPEN;
   if (net_log_.IsLoggingAllEvents()) {
     net_log_.AddEvent(
         NetLog::TYPE_HTTP_TRANSACTION_READ_TUNNEL_RESPONSE_HEADERS,
         make_scoped_refptr(new NetLogHttpResponseParameter(response_.headers)));
   }
 
   if (response_.headers->response_code() == 200)
     return OK;
+  else if (response_.headers->response_code() == 407)
+    return ERR_TUNNEL_CONNECTION_FAILED;
   else
-    return ERR_TUNNEL_CONNECTION_FAILED;
+    return ERR_HTTPS_PROXY_TUNNEL_CONNECTION_RESPONSE;
 }
 
 // SpdyStream::Delegate methods:
 // Called when SYN frame has been sent.
 // Returns true if no more data to be sent after SYN frame.
 bool SpdyProxyClientSocket::OnSendHeadersComplete(int status) {
   DCHECK_EQ(next_state_, STATE_SEND_REQUEST_COMPLETE);
 
   OnIOComplete(status);
 
@@ skipping 92 matching lines @@
     read_callback->Run(status);
   } else if (read_callback_) {
     // If we have a read_callback, the we need to make sure we call it back
     OnDataReceived(NULL, 0);
   }
   if (write_callback)
     write_callback->Run(ERR_CONNECTION_CLOSED);
 }
 
 }  // namespace net