Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

net/http/http_proxy_client_socket_pool_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

[vandebo (ex-Chrome), 2010/12/14 00:30:23]

I'd like to see a unit test (here or at the HttpNetworkTransaction if necessary)
that ensures that when a http_proxy_client_socket returns
ERR_HTTPS_PROXY_TUNNEL_CONNECTION_RESPONSE the connection is not reusable.

[Ryan Hamilton, 2010/12/15 20:14:17]

Just to confirm.  It's ok to reuse the TCP/SSL socket, but not the ProxySocket,
right?

[vandebo (ex-Chrome), 2010/12/15 22:52:38]

Yea, I had a think-o.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_proxy_client_socket_pool.h"
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/mock_host_resolver.h"
@@ skipping 479 matching lines @@
   AddAuthToCache();
 
   int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
                        BoundNetLog());
   EXPECT_EQ(ERR_IO_PENDING, rv);
   EXPECT_FALSE(handle_.is_initialized());
   EXPECT_FALSE(handle_.socket());
 
   data_->RunFor(2);
 
-  EXPECT_EQ(ERR_TUNNEL_CONNECTION_FAILED, callback_.WaitForResult());
+  rv = callback_.WaitForResult();
   EXPECT_FALSE(handle_.is_initialized());
   EXPECT_FALSE(handle_.socket());
+  if (GetParam() == HTTP) {
+    // HTTP Proxy CONNECT responses are not trustworthy
+    EXPECT_EQ(ERR_TUNNEL_CONNECTION_FAILED, rv);
+  } else {
+    // HTTP Proxy CONNECT responses are trustworthy
+    EXPECT_EQ(ERR_HTTPS_PROXY_TUNNEL_CONNECTION_RESPONSE, rv);
+  }
 }
 
 // It would be nice to also test the timeouts in HttpProxyClientSocketPool.
 
 }  // namespace net