Allow a non-200 (or non-407) response for a CONNECT request from an HTTPS pro...

net/http/stream_factory.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_STREAM_FACTORY_H_
 #define NET_HTTP_STREAM_FACTORY_H_
 
 #include <string>
 
 #include "base/ref_counted.h"
@@ skipping 51 matching lines @@
     // to |auth_controller| if it is needed beyond the lifetime of this
     // callback.
     virtual void OnNeedsProxyAuth(const HttpResponseInfo& proxy_response,
                                   HttpAuthController* auth_controller) = 0;
 
     // This is the failure for SSL Client Auth
     // Ownership of |cert_info| is retained by the StreamRequest.  The delegate
     // may take a reference if it needs the cert_info beyond the lifetime of
     // this callback.
     virtual void OnNeedsClientAuth(SSLCertRequestInfo* cert_info) = 0;
+
+    // This is the failure of the CONNECT request through an HTTPS proxy.
+    // Headers can be read from |response_info|, while the body can be read
+    // from |stream|.
+    // Ownership of |response_info| is retained by the StreamRequest.

[vandebo (ex-Chrome), 2010/12/04 00:30:37]

I don't think you need to note the ownership of a const class ref

[Ryan Hamilton, 2010/12/09 21:19:35]

Oh, duh!

+    // Ownership of |stream| is transferred to the delegate.
+    virtual void OnHttpsProxyTunnelConnectionResponse(

[vandebo (ex-Chrome), 2010/12/04 00:30:37]

Connection -> Connect ?

+        const HttpResponseInfo& response_info, HttpStream* stream) = 0;
   };
 
   virtual ~StreamRequest() {}
 
   // When a HttpStream creation process requires a SSL Certificate,
   // the delegate OnNeedsClientAuth handler will have been called.
   // It now becomes the delegate's responsibility to collect the certificate
   // (probably from the user), and then call this method to resume
   // the HttpStream creation process.
   // Ownership of |client_cert| remains with the StreamRequest.  The
@@ skipping 58 matching lines @@
       const std::string& alternate_protocol_str,
       const HostPortPair& http_host_port_pair) = 0;
 
   virtual GURL ApplyHostMappingRules(const GURL& url,
                                      HostPortPair* endpoint) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_STREAM_FACTORY_H_