Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 4932001: Makes the current page dim out when transitioning to instant preview. (Closed)

Created:
10 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Makes the current page dim out when transitioning to instant preview. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66164

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -4 lines) Patch
M chrome/browser/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_container.h View 1 3 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/contents_container.cc View 1 2 chunks +62 lines, -0 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
10 years, 1 month ago (2010-11-13 00:08:33 UTC) #1
Jay Civelli
10 years, 1 month ago (2010-11-15 18:29:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698