Changing the installer switches from wchar_t[] to char[]....

base/command_line_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
+#include "base/basictypes.h"
 #include "base/command_line.h"
-#include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // To test Windows quoting behavior, we use a string that has some backslashes
 // and quotes.
 // Consider the command-line argument: q\"bs1\bs2\\bs3q\\\"
 // Here it is with C-style escapes.
 #define TRICKY_QUOTED L"q\\\"bs1\\bs2\\\\bs3q\\\\\\\""
 // It should be parsed by Windows as: q"bs1\bs2\\bs3q\"
@@ skipping 127 matching lines @@
 #if defined(OS_WIN)
   EXPECT_EQ(L"\"Program\" "
             L"--switch1 "
             L"--switch2=value "
             L"--switch3=\"a value with spaces\" "
             L"--switch4=\"\\\"a value with quotes\\\"\" "
             L"--quotes=\"" TRICKY_QUOTED L"\"",
             cl.command_line_string());
 #endif
 }
+
+// Tests that when AppendArguments is called that both the program and
+// command line strings are equal.
+TEST(CommandLineTest, AppendArguments) {
+  CommandLine cl1(FilePath(FILE_PATH_LITERAL("Program")));
+  cl1.AppendSwitch("switch1");
+  cl1.AppendSwitchASCII("switch2", "foo");
+
+  CommandLine cl2(CommandLine::NO_PROGRAM);
+  cl2.AppendArguments(cl1, true);
+  EXPECT_EQ(cl1.GetProgram().value(), cl2.GetProgram().value());
+  EXPECT_EQ(cl1.command_line_string(), cl2.command_line_string());

[robertshield, 2010/11/14 15:21:31]

Could you also test the new replacement behaviour of AppendArguments when both
CommandLines are not created with NO_PROGRAM?
e.g.
CommandLine c1("Program1");
c1.AppendSwitch("switch1");
CommandLine c2("Program2:);
c2.AppendSwitch("switch2");

c1.AppendArguments(c2, true);
EXPECT_EQ(c1.GetProgram.value(), c2.GetProgram.value());

[tommi (sloooow) - chröme, 2010/11/14 21:28:07]

Done.

+}
+