Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: remoting/protocol/rtp_reader.cc

Issue 4925001: Packetizer/Depacketizer for RTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/rtp_reader.h ('k') | remoting/protocol/rtp_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/rtp_reader.cc
diff --git a/remoting/protocol/rtp_reader.cc b/remoting/protocol/rtp_reader.cc
index b989c4481db2424e3d4d9835fdd63cf7fafd7bec..7e2125052ca480f0d7d631a5767c79f1e7ba4b10 100644
--- a/remoting/protocol/rtp_reader.cc
+++ b/remoting/protocol/rtp_reader.cc
@@ -24,15 +24,25 @@ void RtpReader::Init(net::Socket* socket,
}
void RtpReader::OnDataReceived(net::IOBuffer* buffer, int data_size) {
- RtpPacket packet;
+ RtpPacket* packet = new RtpPacket();
int header_size = UnpackRtpHeader(reinterpret_cast<uint8*>(buffer->data()),
- data_size, packet.mutable_header());
+ data_size, packet->mutable_header());
if (header_size < 0) {
LOG(WARNING) << "Received invalid RTP packet.";
return;
}
- packet.mutable_payload()->Append(buffer, buffer->data() + header_size,
- data_size - header_size);
+
+ int descriptor_size = UnpackVp8Descriptor(
+ reinterpret_cast<uint8*>(buffer->data()) + header_size,
+ data_size - header_size, packet->mutable_vp8_descriptor());
+ if (descriptor_size < 0) {
+ LOG(WARNING) << "Received RTP packet with an invalid VP8 descriptor.";
+ return;
+ }
+
+ packet->mutable_payload()->Append(
+ buffer, buffer->data() + header_size + descriptor_size,
+ data_size - header_size - descriptor_size);
on_message_callback_->Run(packet);
}
« no previous file with comments | « remoting/protocol/rtp_reader.h ('k') | remoting/protocol/rtp_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698