Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 4924001: JavaScript to Value bridge. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Go back to using seconds, use UTC for reliability in the test. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_view_host.cc
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc
index 93abfc6582cc8ea94e13ebcc50cb55bc36bdc1f5..dd04b3c0c78186348b0c0004d85b8a7fff05b003 100644
--- a/chrome/browser/renderer_host/render_view_host.cc
+++ b/chrome/browser/renderer_host/render_view_host.cc
@@ -2195,9 +2195,10 @@ void RenderViewHost::OnDetectedPhishingSite(const GURL& phishing_url,
// to confirm that the URL is really phishing.
}
-void RenderViewHost::OnScriptEvalResponse(int id, bool result) {
- scoped_ptr<Value> result_value(Value::CreateBooleanValue(result));
- std::pair<int, Value*> details(id, result_value.get());
+void RenderViewHost::OnScriptEvalResponse(int id, const ListValue& result) {
+ Value* result_value;
+ result.Get(0, &result_value);
+ std::pair<int, Value*> details(id, result_value);
NotificationService::current()->Notify(
NotificationType::EXECUTE_JAVASCRIPT_RESULT,
Source<RenderViewHost>(this),

Powered by Google App Engine
This is Rietveld 408576698