JavaScript to Value bridge.

JavaScript to Value bridge.

Add more values that we can get back from JavaScript.  Very useful for writing
additional DOMUI browser test, and maybe in other cases as well.

BUG=none
TEST=RenderViewHostTest.ExecuteJavascriptInWebFrameNotifyResult

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68416

[Scott Byer, 2010-12-06 22:37:16]

Do you mind reviewing this?  This ended up being a yak shaving from trying to do
more advanced browser test checking elsewhere, and I decided if I was going to
add another type to what gets converted, I might as well do the right thing and
be as complete as was reasonable.  It looks like you originally added
EvaluateScript back in October.

Thanks.

[sky, 2010-12-06 23:07:07]

Can you also update the documentation to mention the value may be the NullValue.

http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/render_view_host.h (right):

http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
chrome/browser/renderer_host/render_view_host.h:724: void
OnScriptEvalResponse(int id, const ListValue& result);
How come this is a ListValue and not a Value?

[Scott Byer, 2010-12-07 00:03:20]

On 2010/12/06 23:07:07, sky wrote:
> Can you also update the documentation to mention the value may be the
NullValue.

Gladly.  You are talking about the documentation on the
EXECUTE_JAVASCRIPT_RESULT notification?

> 
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> File chrome/browser/renderer_host/render_view_host.h (right):
> 
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> chrome/browser/renderer_host/render_view_host.h:724: void
> OnScriptEvalResponse(int id, const ListValue& result);
> How come this is a ListValue and not a Value?

ListValues can be copied and thus the macros for marshalling them and their
sub-values - across IPC to the browser process work.  Since base Values can't be
copied, none of that works.  Would you expect to find that documented somewhere,
such as in render_messages_internal.h?

-Scott

[sky, 2010-12-07 00:07:22]

On 2010/12/07 00:03:20, Scott Byer wrote:
> On 2010/12/06 23:07:07, sky wrote:
> > Can you also update the documentation to mention the value may be the
> NullValue.
> 
> Gladly.  You are talking about the documentation on the
> EXECUTE_JAVASCRIPT_RESULT notification?

Yes please.

  -Scott

> > 
> >
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> > File chrome/browser/renderer_host/render_view_host.h (right):
> > 
> >
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> > chrome/browser/renderer_host/render_view_host.h:724: void
> > OnScriptEvalResponse(int id, const ListValue& result);
> > How come this is a ListValue and not a Value?
> 
> ListValues can be copied and thus the macros for marshalling them and their
> sub-values - across IPC to the browser process work.  Since base Values can't
be
> copied, none of that works.  Would you expect to find that documented
somewhere,
> such as in render_messages_internal.h?
> 
> -Scott

[Scott Byer, 2010-12-07 00:18:16]

Done.

On 2010/12/07 00:07:22, sky wrote:
> On 2010/12/07 00:03:20, Scott Byer wrote:
> > On 2010/12/06 23:07:07, sky wrote:
> > > Can you also update the documentation to mention the value may be the
> > NullValue.
> > 
> > Gladly.  You are talking about the documentation on the
> > EXECUTE_JAVASCRIPT_RESULT notification?
> 
> Yes please.
> 
>   -Scott
> 
> > > 
> > >
> >
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> > > File chrome/browser/renderer_host/render_view_host.h (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/4924001/diff/9001/chrome/browser/renderer_host...
> > > chrome/browser/renderer_host/render_view_host.h:724: void
> > > OnScriptEvalResponse(int id, const ListValue& result);
> > > How come this is a ListValue and not a Value?
> > 
> > ListValues can be copied and thus the macros for marshalling them and their
> > sub-values - across IPC to the browser process work.  Since base Values
can't
> be
> > copied, none of that works.  Would you expect to find that documented
> somewhere,
> > such as in render_messages_internal.h?
> > 
> > -Scott

[sky, 2010-12-07 00:25:13]

LGTM