Issue 492014: Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492014: Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process i... (Closed)

Created:
11 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash). BUG=30057 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34321

Patch Set 3 : '' #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chrome/browser/extensions/extension_host.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_host.cc	View		3 chunks	+14 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

LGTM. Thanks for fixing this. http://codereview.chromium.org/492014/diff/4/6 File chrome/browser/extensions/extension_host.cc (right): http://codereview.chromium.org/492014/diff/4/6#newcode242 chrome/browser/extensions/extension_host.cc:242: nit: add DCHECK(closed_details->was_extension_renderer) just ...

11 years ago (2009-12-11 01:54:52 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 492014: Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process i... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages