Issue 492009: First batch of GCC fixes for GPU code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492009: First batch of GCC fixes for GPU code. (Closed)

Created:
11 years ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

First batch of GCC fixes for GPU code. This patch addresses signed/unsigned and 64-bit errors. The remaining fixes are more involved requiring changes/ifdefs to get around HWND. There's also a ton of "unused variable" warnings in the auto-generated code. BUG=n/a TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34296

Patch Set 1 #

Patch Set 2 : Minor fixes #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
M	gpu/command_buffer/client/gles2_implementation.cc	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/cmd_parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/command_buffer_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gl_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/x_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/x_utils.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/gpu.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Still need to try this patch out on windows. I'm unable to link any unit ...

11 years ago (2009-12-10 21:22:30 UTC) #1

apatrick

11 years ago (2009-12-10 21:31:12 UTC) #2

LGTM.

The HWND problem might be made better by my next CL. I changed it to
gfx::PluginWindowHandle. That won't work on mac I think but might on linux.

Thanks for fixing it!

Expand Messages | Collapse Messages