Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 492005: Overhaul microbenchmark so that it can be pulled in easily by any package (Closed)

Created:
11 years ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone, ericli
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Overhaul microbenchmark so that it can be pulled in easily by any package This follows the model set by gtest_main.a and adds a microbenchmark_main.a which can be pulled in by any package to do quick microbenchmarking of any of the functions in their tree. This change also includes updates to minijail as an example usage of the microbenchmark code. Last but not least, I fixed a copy and paste error in the copyright and a missing comma in the output as well as updated some comments.

Patch Set 1 #

Patch Set 2 : add to build_platform_packages while minijail links a shipped binary against it #

Total comments: 6

Patch Set 3 : fix cmasone's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -29 lines) Patch
M src/platform/microbenchmark/SConstruct View 1 chunk +4 lines, -6 lines 0 comments Download
M src/platform/microbenchmark/debian/changelog View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/microbenchmark/debian/control View 1 chunk +5 lines, -5 lines 0 comments Download
A src/platform/microbenchmark/debian/dirs View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform/microbenchmark/debian/rules View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M src/platform/microbenchmark/main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/platform/microbenchmark/make_pkg.sh View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/microbenchmark/microbenchmark.h View 1 2 4 chunks +19 lines, -2 lines 0 comments Download
M src/platform/microbenchmark/microbenchmark.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform/minijail/SConstruct View 3 chunks +12 lines, -3 lines 0 comments Download
M src/platform/minijail/debian/rules View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A + src/platform/minijail/getpid_microbenchmark.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + src/platform/minijail/readwrite_microbenchmark.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scripts/build_platform_packages.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Drewry
11 years ago (2009-12-10 16:19:46 UTC) #1
Chris Masone
http://codereview.chromium.org/492005/diff/2001/2005 File src/platform/microbenchmark/debian/rules (right): http://codereview.chromium.org/492005/diff/2001/2005#newcode33 src/platform/microbenchmark/debian/rules:33: mkdir -p $(CURDIR)/debian/chromeos-microbenchmark/usr/lib/ I believe you can use the ...
11 years ago (2009-12-10 17:34:38 UTC) #2
Will Drewry
Fixed/commented! http://codereview.chromium.org/492005/diff/2001/2005 File src/platform/microbenchmark/debian/rules (right): http://codereview.chromium.org/492005/diff/2001/2005#newcode33 src/platform/microbenchmark/debian/rules:33: mkdir -p $(CURDIR)/debian/chromeos-microbenchmark/usr/lib/ On 2009/12/10 17:34:38, cmasone wrote: ...
11 years ago (2009-12-10 18:58:53 UTC) #3
Chris Masone
11 years ago (2009-12-10 20:22:38 UTC) #4
LGTm

On 2009/12/10 18:58:53, Will Drewry wrote:
> Fixed/commented!
> 
> http://codereview.chromium.org/492005/diff/2001/2005
> File src/platform/microbenchmark/debian/rules (right):
> 
> http://codereview.chromium.org/492005/diff/2001/2005#newcode33
> src/platform/microbenchmark/debian/rules:33: mkdir -p
> $(CURDIR)/debian/chromeos-microbenchmark/usr/lib/
> On 2009/12/10 17:34:38, cmasone wrote:
> > I believe you can use the debian/dirs file to create these for you.  The
login
> > manager package does it
> 
> Done.
> 
> http://codereview.chromium.org/492005/diff/2001/2009
> File src/platform/microbenchmark/microbenchmark.h (right):
> 
> http://codereview.chromium.org/492005/diff/2001/2009#newcode39
> src/platform/microbenchmark/microbenchmark.h:39: void SingleTest(bool
> scaffold_only) { _NAME(scaffold_only); } \
> On 2009/12/10 17:34:38, cmasone wrote:
> > Will _NAME be declared at this point in the code?  When this macro gets
> > expanded, it'll dump out this class definition first, and then the TEST
> > declaration after...when the compiler tries to compile SingleTest, won't it
> > barf?
> 
> This should be the MyTest function which mimicks the SingleTest(bool)
prototype.
>  I have  documented that in the comment now.
> 
> http://codereview.chromium.org/492005/diff/2001/2011
> File src/platform/minijail/debian/rules (right):
> 
> http://codereview.chromium.org/492005/diff/2001/2011#newcode38
> src/platform/minijail/debian/rules:38: #           every install.
> On 2009/12/10 17:34:38, cmasone wrote:
> > You tried to wrap to 80, and it seemed to not work out...
> 
> Done.
> 
> Oh how I hate space v. tabs...

Powered by Google App Engine
This is Rietveld 408576698