Issue 4915001: Fix up the excludes so they properly handle paths where the platform subdir i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4915001: Fix up the excludes so they properly handle paths where the platform subdir i... (Closed)

Created:
10 years, 1 month ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix up the excludes so they properly handle paths where the platform subdir is the *first* element in the pathname (ie- mac/foo.mm). But luckily, the other rules have caught the places where this bug would have hit, but nothing says that will always be true. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66118

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	build/common.gypi	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM. Wait for the try result.

Expand Messages | Collapse Messages