Issue 491079: Reapply "wait for connection" feature implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 491079: Reapply "wait for connection" feature implementation (Closed)

Created:
11 years ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Reapply "wait for connection" feature implementation Committed: http://code.google.com/p/v8/source/detail?r=3500

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Comment #

Patch Set 4 : merge #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
M	include/v8-debug.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/debug.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/debug.cc	View		1 chunk	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Hi Sorren This one I checked with both release/debug tests. However, 2 tests look flaky ...

11 years ago (2009-12-17 18:53:02 UTC) #1

Søren Thygesen Gjesse

11 years ago (2009-12-18 11:01:19 UTC) #2

LGTM

I guess that the flakey tests give a TIMEOUT error. They can do that when run
locally depending on the machine used and on whether -j<something> is used.

Expand Messages | Collapse Messages