Reworked devserver so that update images generated are cached in directories named after

devserver.py

Index: devserver.py
diff --git a/devserver.py b/devserver.py
index 8abdb8fe66befd2d1c7fa36b7641d5f143e8b655..2d5a621dd600002139bf3c533ba11d7c83891e98 100755
--- a/devserver.py
+++ b/devserver.py
@@ -133,6 +133,8 @@ if __name__ == '__main__':
                     help='base URL, other than devserver, for update images.')
   parser.add_option('--use_cached', action="store_true", default=False,
                     help='Prefer cached image regardless of timestamps.')
+  parser.add_option('--clear_cache', action="store_true", default=False,

[petkov, 2010/11/13 00:55:18]

Keep options sorted.

+                    help='Clear out all cached deltas and exit')
   parser.add_option('--validate_factory_config', action="store_true",
                     dest='validate_factory_config',
                     help='Validate factory config file, then exit.')
@@ -151,6 +153,20 @@ if __name__ == '__main__':
     static_dir = os.path.realpath('%s/static' % devserver_dir)
     os.system('mkdir -p %s' % static_dir)
 
+  cache_dir = os.path.join(static_dir, 'cache')
+  cherrypy.log('Using cache directory %s' % cache_dir, 'DEVSERVER')
+  if options.clear_cache:
+    # Clear the cache and exit
+    sys.exit(os.system('sudo rm -rf %s' % cache_dir))
+  else:

[petkov, 2010/11/13 00:55:18]

No need for "else:" here...

[dgarrett, 2010/11/15 21:50:33]

Done.

+    if os.path.exists(cache_dir):
+      # Clear all but the last 12 cached deltas
+      cmd = 'cd %s; ls -1tr | head --lines=-12 | xargs rm -rf' % cache_dir

[petkov, 2010/11/13 00:55:18]

ls -ltr returns more than just filenames, right?

I've seen this done through find (e.g., see
src/platform/init/chromeos-cleanup-logs).

[dgarrett, 2010/11/15 21:50:33]

I specifically want it to return more than files. Each entry is normally a
directory containing update.gz, and stateful_image.gz.

+      if os.system(cmd) != 0:
+        cherrypy.log('Failed to clean up old delta cache files with %s' % cmd,
+                     'DEVSERVER')
+        sys.exit(1)
+
   cherrypy.log('Source root is %s' % root_dir, 'DEVSERVER')
   cherrypy.log('Serving from %s' % static_dir, 'DEVSERVER')