Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/cocoa/tab_view.mm

Issue 49042: Remove obsolete TODOs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_view.mm
===================================================================
--- chrome/browser/cocoa/tab_view.mm (revision 12550)
+++ chrome/browser/cocoa/tab_view.mm (working copy)
@@ -129,17 +129,9 @@
draggedController = sourceController;
dragWindow = [draggedController window];
} else {
- // Detach from the current window.
- // TODO(pinkerton): Create a new window, probably with
- // Browser::CreateNewStripWithContents(), but that requires that
- // we make some changes to return the new Browser object.
+ // Detach from the current window and put it in a new window.
draggedController = [sourceController detachTabToNewWindow:self];
dragWindow = [draggedController window];
-
- // TODO(pinkerton): reconcile how the view moves from one window
- // to the other with the TabStrip model wanting to create the tabs.
- // [[sourceController tabController] removeTab:tab_];
- // [[sourceController tabController] addTab:tab_];
[dragWindow setAlphaValue:0.0];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698