Issue 49037: Change the arguments access stub to take both arguments in registers...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49037: Change the arguments access stub to take both arguments in registers... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the arguments access stub to take both arguments in registers rathern than one in a register and one on the stack. Fix a stack height bug in the case that the arguments access stub hit its slow case. Committed: http://code.google.com/p/v8/source/detail?r=1620

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -17 lines)			Patch
	M	src/codegen-ia32.cc	View		4 chunks	+25 lines, -17 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/49037/diff/1/2 File src/codegen-ia32.cc (right): http://codereview.chromium.org/49037/diff/1/2#newcode6345 Line 6345: __ int3(); Oops. Removed.

11 years, 9 months ago (2009-03-26 12:45:00 UTC) #2

LGTM!

Expand Messages | Collapse Messages