Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 49036: Final wiring of the distribution strings... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/google_chrome_distribution_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_chrome_distribution.cc
===================================================================
--- chrome/installer/util/google_chrome_distribution.cc (revision 12500)
+++ chrome/installer/util/google_chrome_distribution.cc (working copy)
@@ -165,8 +165,9 @@
}
std::wstring GoogleChromeDistribution::GetAlternateApplicationName() {
- // TODO(cpu): return the right localized strings when it arrives.
- return L"";
+ const std::wstring& alt_product_name =
+ installer_util::GetLocalizedString(IDS_OEM_MAIN_SHORTCUT_NAME_BASE);
Glenn Wilson 2009/03/26 00:53:55 I'm assuming that IDS_OEM_MAIN_SHORTCUT_NAME_BASE
+ return alt_product_name;
}
std::wstring GoogleChromeDistribution::GetInstallSubDir() {
@@ -206,8 +207,9 @@
}
std::wstring GoogleChromeDistribution::GetAppDescription() {
- // TODO(cpu): Wire the actual localized strings when they arrive.
- return L"";
+ const std::wstring& app_description =
+ installer_util::GetLocalizedString(IDS_SHORTCUT_TOOLTIP_BASE);
+ return app_description;
}
int GoogleChromeDistribution::GetInstallReturnCode(
« no previous file with comments | « no previous file | chrome/installer/util/google_chrome_distribution_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698