Issue 49036: Final wiring of the distribution strings...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49036: Final wiring of the distribution strings... (Closed)

Created:
11 years, 9 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Glenn Wilson

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Final wiring of the distribution strings - updated unittests BUG=1640034 BUG=1522969 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12567

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	chrome/installer/util/google_chrome_distribution.cc	View	1	2 chunks	+6 lines, -4 lines	1 comment	Download
	M	chrome/installer/util/google_chrome_distribution_unittest.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Glenn Wilson

lgtm http://codereview.chromium.org/49036/diff/2001/3001 File chrome/installer/util/google_chrome_distribution.cc (right): http://codereview.chromium.org/49036/diff/2001/3001#newcode169 Line 169: installer_util::GetLocalizedString(IDS_OEM_MAIN_SHORTCUT_NAME_BASE); I'm assuming that IDS_OEM_MAIN_SHORTCUT_NAME_BASE gets automatically ...

11 years, 9 months ago (2009-03-26 00:53:55 UTC) #2

cpu_(ooo_6.6-7.5)

11 years, 9 months ago (2009-03-26 01:14:42 UTC) #3

On 2009/03/26 00:53:55, gwilson wrote:
> lgtm
> 
> http://codereview.chromium.org/49036/diff/2001/3001
> File chrome/installer/util/google_chrome_distribution.cc (right):
> 
> http://codereview.chromium.org/49036/diff/2001/3001#newcode169
> Line 169: installer_util::GetLocalizedString(IDS_OEM_MAIN_SHORTCUT_NAME_BASE);
> I'm assuming that IDS_OEM_MAIN_SHORTCUT_NAME_BASE gets automatically generated
> in installer_util_strings.h from the grd file?

Yeah, the magic python script generates this name and it matches the first
locale (ar). Go argentina Go!

We still need to manually test some locales :(

Expand Messages | Collapse Messages

Issue 49036: Final wiring of the distribution strings... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages