Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 49035: Linux UI theming:... (Closed)

Created:
11 years, 9 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux UI theming: - Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance). - Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12516

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M base/gfx/gtk_util.h View 1 chunk +4 lines, -1 line 0 comments Download
M base/gfx/gtk_util.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 2 chunks +4 lines, -4 lines 1 comment Download
M chrome/browser/gtk/menu_gtk.cc View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
11 years, 9 months ago (2009-03-25 22:21:15 UTC) #1
Lei Zhang
LGTM. Without this, if the user has a high contrast theme, everything looks awful.
11 years, 9 months ago (2009-03-25 23:14:38 UTC) #2
Evan Martin
I kind of hate this, but I guess it's ok for now.
11 years, 9 months ago (2009-03-25 23:18:12 UTC) #3
Dean McNamee
Woah woah buddy, what's up with changing Omnibox? :) We are talking about 16 bytes ...
11 years, 9 months ago (2009-03-26 12:32:30 UTC) #4
Dean McNamee
11 years, 9 months ago (2009-03-26 12:33:43 UTC) #5
http://codereview.chromium.org/49035/diff/1/5
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (left):

http://codereview.chromium.org/49035/diff/1/5#oldcode30
Line 30: GDK_COLOR_RGB(255, 255, 255),  // SecurityLevel INSECURE: White.
Also, this code matched windows, and is part of LocationBarView, and will be
merge back when we go to views, so I don't see why we were changing it.

Powered by Google App Engine
This is Rietveld 408576698