Issue 49028: Use OpenThread instead of DuplicateHandle in Win32 profiler implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49028: Use OpenThread instead of DuplicateHandle in Win32 profiler implementation. (Closed)

Created:
11 years, 9 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Use OpenThread instead of DuplicateHandle in Win32 profiler implementation. OpenThread doesn't fail in Chrome sandbox, while DuplicateHandle does. Committed: http://code.google.com/p/v8/source/detail?r=1604

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated comment #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	src/platform-win32.cc	View	1	1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM This is great! http://codereview.chromium.org/49028/diff/1/2 File src/platform-win32.cc (right): http://codereview.chromium.org/49028/diff/1/2#newcode1818 Line 1818: if (IsProfiling()) { I ...

11 years, 9 months ago (2009-03-25 09:18:00 UTC) #2

Mikhail Naganov

11 years, 9 months ago (2009-03-25 09:34:32 UTC) #3

http://codereview.chromium.org/49028/diff/1/2
File src/platform-win32.cc (right):

http://codereview.chromium.org/49028/diff/1/2#newcode1818
Line 1818: if (IsProfiling()) {
On 2009/03/25 09:18:00, Søren Gjesse wrote:
> I think the comment needs to be changed a bit as still says "duplicate the
> handle". It could say "open an additional handle" and maybe mention while
> DuplicateHandle is not used.

Done.

Expand Messages | Collapse Messages