Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 49023: Explicitly instantiate the string16 backer exactly once (Closed)

Created:
11 years, 9 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Explicitly instantiate the string16 backer exactly once, avoiding problems in shared library builds and an Apple ld bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12406

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M base/string16.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
M base/string16.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
Dispatching to interested or potentially interested parties. The code doesn't really warrant multiple reviewers, but ...
11 years, 9 months ago (2009-03-24 22:39:10 UTC) #1
dank
11 years, 9 months ago (2009-03-24 23:06:34 UTC) #2
Sweet.

Powered by Google App Engine
This is Rietveld 408576698