Issue 49023: Explicitly instantiate the string16 backer exactly once

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49023: Explicitly instantiate the string16 backer exactly once (Closed)

Created:
11 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Dean McNamee, TVL, agl, dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Explicitly instantiate the string16 backer exactly once, avoiding problems in shared library builds and an Apple ld bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12406

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
	M	base/string16.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
	M	base/string16.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Mark Mentovai

Dispatching to interested or potentially interested parties. The code doesn't really warrant multiple reviewers, but ...

11 years, 9 months ago (2009-03-24 22:39:10 UTC) #1

Sweet.