Issue 490023: Enabled a number of worker tests on various platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490023: Enabled a number of worker tests on various platforms. (Closed)

Created:
11 years ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
levin

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Timur Iskhodzhanov, jam, dank, stuartmorgan, Paweł Hajdan Jr.

Visibility:
Public.

Description

Enabled a number of worker tests on various platforms. Added new SingleSharedWorker and MultipleSharedWorker tests, and enabled a bunch of other tests after marking them flaky/excluding them from valgrind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34429

Patch Set 1 #

Patch Set 2 : Removed erroneous edit to websharedworker_stub.cc #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -23 lines)			Patch
M	chrome/test/data/valgrind/ui_tests.gtest.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/workers/multi_worker.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/workers/single_worker.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/workers/worker_common.js	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/test/data/workers/worker_utils.js	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/worker/worker_uitest.cc	View	7 chunks	+11 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

I started out wanting to check in some shared worker tests I had hanging around ...

11 years ago (2009-12-11 23:06:04 UTC) #1

LGTM

Expand Messages | Collapse Messages