Issue 490021: gclient: Add a minimum git version check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490021: gclient: Add a minimum git version check. (Closed)

Created:
11 years ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, djmm

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

gclient: Add a minimum git version check. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34377

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	gclient_scm.py	View		2 chunks	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/490021/diff/1/2 File gclient_scm.py (right): http://codereview.chromium.org/490021/diff/1/2#newcode193 gclient_scm.py:193: min_version_list = map(int, min_version.split('.')) Nice idea, I wouldn't ...

11 years ago (2009-12-11 19:51:54 UTC) #2

djmm

11 years ago (2009-12-11 20:34:51 UTC) #3

On 2009/12/11 19:51:54, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://codereview.chromium.org/490021/diff/1/2
> File gclient_scm.py (right):
> 
> http://codereview.chromium.org/490021/diff/1/2#newcode193
> gclient_scm.py:193: min_version_list = map(int, min_version.split('.'))
> Nice idea, I wouldn't have thought about that.

LGTM

Expand Messages | Collapse Messages