Issue 4886004: Fix some bugs in paint manager. Some of the class members were not getting...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4886004: Fix some bugs in paint manager. Some of the class members were not getting... (Closed)

Created:
10 years, 1 month ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix some bugs in paint manager. Some of the class members were not getting initialized in the constructor. Also, when a manual callback was executed, if a regular fluch happened to come in the intervening time, we would cause an assertion failure because it would always try to paint. Now when we get the callback, we can ignore it if there is already a flush pending.

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	ppapi/cpp/paint_manager.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

huanr

10 years, 1 month ago (2010-11-12 23:38:42 UTC) #2

LGTM.

nit: in your CL description fluch -> flush

On 2010/11/12 23:35:44, brettw wrote:

Expand Messages | Collapse Messages